cc'd Alessandro and rtc list as this is within RTC. I'll happilly take it through IIO given the dependency, but I would like an Ack from the RTC side. On 09/10/13 21:03, Srinivas Pandruvada wrote: > Open sensor hub when module is loaded and close when module is removed. > This helps saving power by opening HID transport only when there is an > user. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > --- > drivers/rtc/rtc-hid-sensor-time.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c > index 7273b01..1fe170c 100644 > --- a/drivers/rtc/rtc-hid-sensor-time.c > +++ b/drivers/rtc/rtc-hid-sensor-time.c > @@ -279,15 +279,28 @@ static int hid_time_probe(struct platform_device *pdev) > return ret; > } > > + ret = sensor_hub_device_open(hsdev); > + if (ret) { > + dev_err(&pdev->dev, "failed to open sensor hub device!\n"); > + goto err_open; > + } > + > time_state->rtc = devm_rtc_device_register(&pdev->dev, > "hid-sensor-time", &hid_time_rtc_ops, > THIS_MODULE); > > if (IS_ERR(time_state->rtc)) { > dev_err(&pdev->dev, "rtc device register failed!\n"); > - return PTR_ERR(time_state->rtc); > + ret = PTR_ERR(time_state->rtc); > + goto err_rtc; > } > > + return 0; > + > +err_rtc: > + sensor_hub_device_close(hsdev); > +err_open: > + sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TIME); > return ret; > } > > @@ -295,6 +308,7 @@ static int hid_time_remove(struct platform_device *pdev) > { > struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; > > + sensor_hub_device_close(hsdev); > sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TIME); > > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html