Hi Tommy, On Thu, Sep 05, 2013 at 05:50:48AM +0000, yunkang.tang@xxxxxxxxxxx wrote: > <Change list> > - Calculate the device's dimension in alps_identify(). > - Change the logic of packet decoding. > - Add the new data process logic. It appears that your mailer damaged the patch converting all tabs to single spaces. Please consider using an alternative MTA (mutt, or maybe git send-email) to post your patches. It also apperas that there are several changes (support for never hardware, tweaks to the older protocols) going rolled into a single patch, would it be possible to split them into separate patches, please? > - Change the dev2's name from "PS/2 Mouse" to "ALPS Touchpad". Hmm, the secondary device is never a touchpad but either trackpoint (for confirmed dualpoint devices) or "something" we do not quite know what. Why are you marking it as a touchpad? Also, you forgot to add your "Signed-off-by: ..." as per Documentation/SubmittingPatches Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html