And this time also attached... On Sat, Sep 7, 2013 at 9:31 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > Hi > > On Sat, Sep 7, 2013 at 5:22 AM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: >> On Fri, Sep 06, 2013 at 06:00:29PM -0700, Linus Torvalds wrote: >>> On Fri, Sep 6, 2013 at 5:58 PM, Dmitry Torokhov >>> <dmitry.torokhov@xxxxxxxxx> wrote: >>> > >>> > The patch still had problems so I'd revert it and wii bits and try again later. >>> >>> Ok. Mind giving me a list of commits, so that I don't have to do a >>> trial-and-error thing? I know the primary commit that causes problems, >>> but there are commits that seem to depend on it.. >> >> >> Sorry for the delay. I believe you need to revert: >> >> 73f8645 HID: wiimote: add support for Guitar-Hero drums >> 61e0065 Input: introduce BTN/ABS bits for drums and guitars >> >> Hmm... there also was "HID: wiimote: add support for Guitar-Hero >> guitars" but I do not see it... > > The commits to revert are: > > commit 61e00655e9cb82e034eb72b95a51072e718d14a7 > Author: David Herrmann <dh.herrmann@xxxxxxxxx> > Date: Mon Aug 26 19:14:46 2013 +0200 > > Input: introduce BTN/ABS bits for drums and guitars > > commit 73f8645db1913ab2475ec3c1cee8d5f748963aa7 > Author: David Herrmann <dh.herrmann@xxxxxxxxx> > Date: Mon Aug 26 19:14:47 2013 +0200 > > HID: wiimote: add support for Guitar-Hero drums > > commit 8e22ecb603c88b7397ab2e80b7b0811b8a1318f5 > Author: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@xxxxxxxxx> > Date: Mon Aug 26 19:14:48 2013 +0200 > > HID: wiimote: add support for Guitar-Hero guitars > > Last one is not from me, so I guess that's why Dmitry missed it. And > sorry for the delay, stupid UTC+1.. > The bug only occurs for multi-touch devices (their ABS_* bits are >>0x1f), that's why I didn't see it happening during my tests.. > > If you didn't revert it, yet, attached (and inlined) is a patch which > reverts the ABS_MAX change and just moves the new identifiers in > between the others. On top of 3.12-rc1, this should fix all issues. If > you already reverted the patches, I guess we will just push it in > linux-next again and wait for 3.13? > > Thanks > David [..snap..]
Attachment:
0001-Revert-Fix-Input-introduce-BTN-ABS-bits-for-drums-an.patch
Description: Binary data
