Re: [PATCH 14/14] HID: check for NULL field when setting values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Aug 2013, Jiri Kosina wrote:

> From: Kees Cook <keescook@xxxxxxxxxxxx>
> 
> Defensively check that the field to be worked on is not NULL.

Applied.

> 
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
>  drivers/hid/hid-core.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 55798b2..192be6b 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1206,7 +1206,12 @@ EXPORT_SYMBOL_GPL(hid_output_report);
>  
>  int hid_set_field(struct hid_field *field, unsigned offset, __s32 value)
>  {
> -	unsigned size = field->report_size;
> +	unsigned size;
> +
> +	if (!field)
> +		return -1;
> +
> +	size = field->report_size;
>  
>  	hid_dump_input(field->report->device, field->usage + offset, value);
>  
> -- 
> Jiri Kosina
> SUSE Labs
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux