Hi Michael, On Tue, Aug 20, 2013 at 11:34:32AM +0200, Michael Grzeschik wrote: > On Tue, Aug 20, 2013 at 03:34:33AM +0200, Samuel Ortiz wrote: > > On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote: > > > In case of devicetree, we currently don't have a way to append pdata for > > > the touchscreen. The current approach is to bail out in that case. > > > This patch makes it possible to probe the touchscreen without pdata > > > and use zero as default values for the atox and ato adc conversion. > > Would that still make the touchscreen somehow functional ? > > Yes, it still works. It just defaults to zero values in no pdata case. > > > If that's the case, and if Dmitry is fine with the ts part of this > > patch, could you please separate the mfd part of this patch into a > > separate one ? > > Why? To avoid cross tree commits as much as possible. > The purpose of this patch is to have both cases working, pdata and no > pdata. I understood that part. But you can still split the patch in 2 as the ts driver will not be probed without pdata until the mfd patch is merged upstream. > This patch is actually fixing the patch of Michael Thalmeier. > There we changed the mfd and touch in one patch as well. There was a build time dependency between the ts driver and the MFD changes, so the patch had to be merged atomically. That is not the case with your patch. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
