On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote: > Hello Greg, > looking through the patch I found the following: > > > > In hid-roccat-kone.c, PROFILE_ATTR macro: > The line > .private = &profile_numbers[number], > should read > .private = &profile_numbers[number-1], Ah, ok, thanks, will fix up. > Regarding the compiler warning about unused pyra_sysfs_write_settings: > The attribute is indeed readwrite, but the code to write is not standard > code. The read function was created with the PYRA_SYSFS_R macro and the > write function was written manually. Used were both by > PYRA_BIN_ATTRIBUTE_RW. > In this case I would keep the PYRA_SYSFS_* macros standalone so that the > calling code looks like this: > > PYRA_SYSFS_W(control, CONTROL); > PYRA_SYSFS_RW(info, INFO); > PYRA_SYSFS_RW(profile_settings, PROFILE_SETTINGS); > PYRA_SYSFS_RW(profile_buttons, PROFILE_BUTTONS); > PYRA_SYSFS_R(settings, SETTINGS); > > PYRA_BIN_ATTRIBUTE_W(control, CONTROL); > PYRA_BIN_ATTRIBUTE_RW(info, INFO); > PYRA_BIN_ATTRIBUTE_RW(profile_settings, PROFILE_SETTINGS); > PYRA_BIN_ATTRIBUTE_RW(profile_buttons, PROFILE_BUTTONS); > PYRA_BIN_ATTRIBUTE_RW(settings, SETTINGS); Hm, I'll look this over again and see if I can make it better. But why are you using a "non standard" write function? What is special here about this? > Another thing: Why does nobody (besides me) use the get_maintainer.pl > script, so I have to search manually for patches regarding my code? I did use it: $ ./scripts/get_maintainer.pl --file drivers/hid/hid-roccat-kone.c Jiri Kosina <jkosina@xxxxxxx> (maintainer:HID CORE LAYER) linux-input@xxxxxxxxxxxxxxx (open list:HID CORE LAYER) linux-kernel@xxxxxxxxxxxxxxx (open list) You aren't listed there, perhaps a MAINTAINERS entry needs to be added? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
