Re: [PATCH] hid-holtekff: don't push static constants on stack for %*ph

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Aug 2013, Andy Shevchenko wrote:

> There is no need to pass constants via stack. The width may be explicitly
> specified in the format.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/hid/hid-holtekff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9a8f051..9325545 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,
>  		holtekff->field->value[i] = data[i];
>  	}
>  
> -	dbg_hid("sending %*ph\n", 7, data);
> +	dbg_hid("sending %7ph\n", data);
>  
>  	hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);

Applied, thanks Andy.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux