On Wed, 17 Jul 2013, David Herrmann wrote: > >> + > >> + /* led_work is spawned by input_dev callbacks, but doesn't access the > >> + * parent input_dev at all. Once all input devices are removed, we > >> + * know that led_work will never get restarted, so we can cancel it > >> + * synchronously and are safe. */ > >> + cancel_work_sync(&hid->led_work); > > > > You missed the multi-lines comment formatting style on this one :) > > The ./net/ subsystem uses these comments quite a lot and there was a > discussion between davem and linus with the conclusion that these > comments are ok. But I actually don't care, so I can change to normal > CodingStyle. I once got grilled by Dave for submitting patch to netdev with such comment, but that didn't change my opinion, and I don't care for my subsystem :) -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html