Hi Alexander,
On Sat, Jul 13, 2013 at 08:25:49AM +0400, Alexander Shiyan wrote:
> +
> + for (i = 0; i < MAX13XXX_NUM_BUTTONS; i++)
> + if (priv->enabled & BIT(i)) {
> + ret = mc13xxx_irq_request(priv->mc13xxx,
> + priv->devtype->btn_def[i].irq,
> + mc13xxx_pwrbutton_irq, NULL,
> + priv);
> + if (!ret)
> + continue;
I'd rather we continued requesting interrupts in probe() as opposed to
open(). I believe the driver should acquire all resources it needs when
binding, instead of later.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
