Hi Matteo, On Sat, Jul 06, 2013 at 12:18:32AM +0200, Matteo Delfino wrote: > * Fix version recognition in elantech_set_properties > > The new hardware reports itself as v7 but the packets' > structure is unaltered. > > * Fix packet type recognition in elantech_packet_check_v4 > > The bitmask used for v6 is too wide, only the last three bits of > the third byte in a packet (packet[3] & 0x03) are actually used to > distinguish between packet types. > Starting from v7, additional information (to be interpreted) is > stored in the remaining bits (packets[3] & 0x1c). > In addition, the value stored in (packet[0] & 0x0c) is no longer > a constant but contains additional information yet to be deciphered. > This change should be backwards compatible with v6 hardware. > > Additional-author: Giovanni Frigione <gio.frigione@xxxxxxxxx> > Signed-off-by: Matteo Delfino <kendatsuba@xxxxxxxxx> Thank you for the patch, unfortunately your mailer line-wrapped it and it can't be applied. Could you please resend it using MUA that does not perform line-wrapping? Also, now that you only use (packet[3] & 0x03) to determine packet type, could you turn series of 'if' statements in elantech_packet_check_v4() into a 'switch'? Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
