Re: [PATCH v3] Add OLPC AP-SP input driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 28, 2013 at 12:20 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>> +static void olpc_apsp_close(struct serio *port)
>> +{
>> +     struct olpc_apsp *priv = port->port_data;
>> +     unsigned int tmp;
>> +
>> +     if (--priv->open_count == 0) {
>
> Both need locking. It looks like you need the song and dance similar to
> what i8042 has to do with it's multiplexed ports. Or ps2mult.c...

I thought they would both be locked already, due to this comment in serio.c:

/* called from serio_driver->connect/disconnect methods under serio_mutex */

Or am I missing something there?

Thanks
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux