On Wed, Jun 12, 2013 at 04:02:00PM +0200, Sebastian Andrzej Siewior wrote: > >> By keep the regmap code you mean I am allowed to remove the regmap > >> usage in mfd (keep patch #1) or do you insist on adding its usage in > >> iio and input? > > I insist on keeping it on the MFD driver, i.e. _not_ keeping patch #1. > > This forces me redo a few things and most likely adding it to the > iio and input driver to be consistent here. I'm not asking for that. The current MFD code uses regmap fine without the iio and input using it, I don't see why you would have to add regmap support there. > Could you please give a reason why using the regmap here is a good > thing? I mentioned a few why it is not and why is better to leave it > out. Yes, and I'm not convinced obviously. regmap prevents you from open coding your MMIO access, and this is the right approach. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
