Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:47PM +0200, Sebastian Andrzej Siewior wrote: > The MFD part uses regmap without caching and is the only user of the > regmap. The child drivers, that is input(touch) and iio(adc), use direct > reg access. > There is a patch which converts them to use regmap as well but I see no > benefit at all doing this. There is a direct MMIO bus access with no > need to cache values like for I2C or SPI devices. Furthermore, most (if > not all) of the access done by the touch & ADC driver read volatile > register. > Therefore this patch removes regmap part of the driver. NAK. Using regmap is better than open coding your register accesses, and the children not using this API is not a reason for the MFD driver to do the same. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
