Mark Brown wrote: > On Thu, Jun 06, 2013 at 11:40:50AM +0100, Nick Dyer wrote: > >> I am more worried about the address pointer handling and the I2C retries. > > The retries can just be done further up the stack? All regmap is doing > with I/O errors is punting them straight back up to the caller so the > caller can retry just as well using regmap as it can using the raw I/O > protocol. It would have to be put into users of the debugfs interface as well. There's quite tight timing required to make it work properly (see patch [40/53]). > Without seeing the address thing it's hard to comment. Patch [36/53]. If the T5 message processor is from address 100-110, you can do a read of 50 bytes starting at address 100, and it will return 10 messages, but anything in regmap that tries to do bounds checking would get confused, I think. Also, we would like to implement address pointer caching. maXTouch allows us to skip the address part of the i2c transaction if the address pointer in the chip hasn't changed. This speeds up interrupt handler slightly. But it requires extra housekeeping at a low level to remember what the address pointer was on the previous transaction to know whether to send it or not. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
