On Mon, May 27, 2013 at 09:12:02PM +0200, Sebastian Andrzej Siewior wrote: > Things that can be done to done without using make up: > - reduce config_inp from 20 elements to 4 > The loop goes 0…3 so elements 4…19 remain unused. > - put the shift for analog_line into one line, since config_inp is u32 we > don't need to worry about sign extension, > - check if he DT values are 0…3 as expected > - replace "err = -EINVAL; goto err" with "return -EINVAL;" as there is no > cleanup and this is less code > - pull out "config[analog_line[i]][0…3];" from the switch case and use > magic to the 0…3 correct. > - since we removed so much lines, spent a few to get > "config[an_line][wi_order];" done. > - get rid of "val32, wires_conf" and assign the values directly. This is > just init code but we can still save a few cycles. > - remove titsc_config_wires() from resume path. ->bit_yn & friends are only > written once and not changed so as long as we assume that our DDR will > have no biflips we can skip that. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > + analog_line[i] = (ts_dev->config_inp[i] & 0xF0) >> 4; > wire_order[i] = ts_dev->config_inp[i] & 0x0F; > + if (WARN_ON(analog_line[i] > 4)) > + return -EINVAL; > + if (WARN_ON(wire_order[i] > 4)) > + return -EINVAL; Formatting is still a bit off here... Thanks, -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
