On Tue, May 28, 2013 at 04:07:46PM +0800, Barry Song wrote: > 2013/5/28 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>: > > Hi Barry, > > > > On Tue, May 28, 2013 at 10:47:38AM +0800, Barry Song wrote: > >> + /* > >> + * For a typical Linux system, we report KEY_SUSPEND to trigger apm-power.c > >> + * to queue a SUSPEND APM event > >> + */ > >> + input_event(pwrcdrv->input, EV_PWR, KEY_SUSPEND, 1); > >> + input_sync(pwrcdrv->input); > >> + > >> + /* > >> + * Todo: report KEY_POWER event for Android platforms, Android PowerManager > >> + * will handle the suspend and powerdown/hibernation > >> + */ > >> + > > ... > > > >> + > >> + pwrcdrv->input->evbit[0] = BIT_MASK(EV_PWR) | BIT_MASK(EV_KEY); > >> + set_bit(KEY_POWER, pwrcdrv->input->keybit); > > > > Why are we setting up KEY_POWER if we do not send this event? > > For Android products, we send KEY_POWER to let Android PM trigger > SUSPEND. that is left to be done. OK, but then we should be adding capabilities when we are ready to send KEY_POWER events. I'll apply without KEY_POWER. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
