On Wed, May 29, 2013 at 11:45 AM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > mt_free_input_name() was never called during .remove(): > hid_hw_stop() removes the hid_input items in hdev->inputs, and so the > list is therefore empty after the call. In the end, we never free the > special names that has been allocated during .probe(). > > Restore the original name before freeing it to avoid acessing already > freed pointer. > > I just spotted this one yesterday... My guess is that this way is safe (without > a locking mechanism to prevent accessing hi->input->name), but I'm not 100% sure. Hi Jiri, Benjamin. What do you think about patch I just sent? P.S. Benjamin, I re-used your commit message, I think you have no objections. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
