On 05/29/2013 01:12 PM, Mark Brown wrote: > On Wed, May 29, 2013 at 10:46:42AM +0200, Sebastian Andrzej Siewior wrote: >> Without this, devm_regmap_init_mmio() creates & uses a simple >> spin_lock() and this should be enough. Within the probe function the >> registers are read and written in process context. Later they are >> accessed from the ISR and lockdep complains because now the lock is >> taken suddenly with IRQs enabled. Currently I don't see any other way to >> keep lockdep quiet than doing this. > > This is not a good place to make this change, there's nothing specific > to the device here and in actual fact there's already a change in the > works from Lars-Peter Clausen converting the spinlock to always use > spin_lock_irqsave() so it should be resolved soon. The thread was on > lkml in the past few days. Yes, this patch shouldn't be necessary in next/master anymore. For the record the patch can be found here: https://patchwork.kernel.org/patch/2609721/ - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html