Re: [PATCH 13/26] HID: wiimote: add extension hotplug support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 23 May 2013, David Herrmann wrote:

[ ... snip ... ]
> >  static void wiimote_init_worker(struct work_struct *work)
> > @@ -655,6 +1129,30 @@ static void wiimote_init_worker(struct work_struct *work)
> >
> >         if (wdata->state.devtype == WIIMOTE_DEV_PENDING)
> >                 wiimote_init_detect(wdata);
> 
> We need an additional "wiimote_init_hotplug(wdata);" in this if-clause
> for devices with built-in MP to detect it right during init.
> Otherwise, MP is not initialized until you plug some other extension.
> That's because the MP-timer is disabled for devices with built-in MP.
> Other than that I didn't get any bug-reports. And I haven't found any
> bugs, either.
> 
> I want to avoid resending the whole series, so I will send a fixup
> patch on top of your branch once you applied it (if that is ok?).

Hi David,

that is certainly OK. I just haven't yet finished reviewing the whole lot, 
as it's quite some code :)

Please send the followup patch to this thread, marking it [27/26] or 
some such :) to make it clear that it's a followup to the series.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux