Hi Dmitry, On 06.05.2013 05:24, Dmitry Torokhov wrote: > On Thu, Apr 25, 2013 at 01:33:52PM +0200, Daniel Mack wrote: >> In preparation for DT bindings, we have to store all runtime information >> inside struct ads7846. Add more variable to struct ads7846 and refactor >> some code so the probe-time supplied pdata is not used from any other >> function than the probe() callback. >> > > I think more common pattern is to allocate platform data structure when > parsing device tree, often with devm_kzalloc() so it is cleaned up after > driver is unbound. That was exactly my first approach as well, but I refrained from it due to the function pointers in the struct, which I didn't want to carry around for the DT case as they will always be unused. So I don't know - I can switch back to that if you still want me to. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
