Re: [PATCH] Drivers: HID: fix warnings: from is u16 which never < 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 7 Apr 2013, Chen Gang wrote:

> 
>   from is u16 which never < 0.
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
>  drivers/hid/hid-icade.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-icade.c b/drivers/hid/hid-icade.c
> index 09dcc04..76b5a75 100644
> --- a/drivers/hid/hid-icade.c
> +++ b/drivers/hid/hid-icade.c
> @@ -159,7 +159,7 @@ static const struct icade_key icade_usage_table[30] = {
>  
>  static const struct icade_key *icade_find_translation(u16 from)
>  {
> -	if (from < 0 || from > ICADE_MAX_USAGE)
> +	if (from > ICADE_MAX_USAGE)
>  		return NULL;
>  	return &icade_usage_table[from];
>  }

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux