Re: [PATCH v2 1/2] input: st1232: Add reset pin handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

2013/4/10 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>:
> Hi Dmitry,
>
> On Tuesday 09 April 2013 23:51:14 Dmitry Torokhov wrote:
>> On Mon, Apr 08, 2013 at 02:52:26PM +0200, Bastian Hecht wrote:
>
> [snip]
>
>> > +           error = devm_gpio_request(&client->dev, ts->reset_gpio, NULL);
>>
>> Frankly I do not like mixing managed and noon-managed resources. Maybe
>> the entire driver needs to be converted to managed resources?
>
> I've just sent a patch to do so.

Thanks Laurent! I've tested it - works fine.

Dimitri, I've addressed your suggestions and use gpio_valid and have
reordered the probing for platform and OF data. Thanks for your
feedback. I've based my changes on top of it and will post it shortly.

Cheers,

 Bastian
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux