On 18:33 Thu 04 Apr , Dmitry Torokhov wrote: > Hi Oskar, > > On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.andero@xxxxxxxxxxxxxx wrote: > > From: Aleksej Makarov <aleksej.makarov@xxxxxxxxxxxxxx> > > > > When waking up the platform by pressing a specific key, sending a > > release on that key makes it impossible to react on the event in > > user-space. > > > > No, we can not simply not release keys after resume from suspend, as > this leads to keys being stuck. Consider you are holding an 'I' key on > your external USB keyboard and close your laptop's lid. Then you release > the key and leave. Later you come back, open the lid waking the laptop > and observe endless stream of 'I' in your open terminal. You're absolutely right. But I guess you also see the case that the patch is trying to fix, right? To explain our use-case: We have a physical camera button on some devices. When the user long-presses the button, the system will wake up and jump directly in to the camera application. > Maybe we should release the keys during suspend time? I am not sure how > Android infrastructure will react to this though... That sounds like a good idea! Let me do some testing on that. Thanks! -Oskar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
