Re: [PATCH 2/2] Input: eeti_ts - Remove redundant null check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 28, 2013 at 01:23:42PM +0530, Sachin Kamat wrote:
> 'pdata' is already dereferenced earlier. Hence this check is
> meaningless.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
>  drivers/input/touchscreen/eeti_ts.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
> index 55255a9..8fe5086 100644
> --- a/drivers/input/touchscreen/eeti_ts.c
> +++ b/drivers/input/touchscreen/eeti_ts.c
> @@ -206,8 +206,7 @@ static int eeti_ts_probe(struct i2c_client *client,
>  	if (err < 0)
>  		goto err1;
>  
> -	if (pdata)
> -		priv->irq_active_high = pdata->irq_active_high;
> +	priv->irq_active_high = pdata->irq_active_high;
>  
>  	irq_flags = priv->irq_active_high ?
>  		IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
> -- 
> 1.7.4.1
> 

Applied both, thank you Sachin.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux