Re: [PATCH] Input: imx_keypad - use devm_ functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

On Wed, Mar 13, 2013 at 01:21:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>  
> @@ -572,15 +546,6 @@ static int imx_keypad_remove(struct platform_device *pdev)
>  
>  	input_unregister_device(keypad->input_dev);
>  

With managed input devices input_unregister_device() is not needed
either, please try removing imx_keypad_remove() altogether.

Thanks.

> -	free_irq(keypad->irq, keypad);
> -	clk_put(keypad->clk);
> -
> -	iounmap(keypad->mmio_base);
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	release_mem_region(res->start, resource_size(res));
> -
> -	kfree(keypad);
> -
>  	return 0;
>  }
>  
> -- 
> 1.7.9.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux