Re: [PATCH 3/7] input: atmel_mxt_ts: check mxt224 family before writing touchscreen voltage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 20, 2013 at 2:22 PM, Peter Meerwald <pmeerw@xxxxxxxxxx> wrote:
> Hello Benson,

>> The driver does read out a supported object table from the device
>> during initialize before handle_pdata. What sort of problem is there
>> in trying to write the voltage to a non existent T28 object?  If the
>> object is missing, then mxt_write_object for voltage should simply
>> return -EINVAL, and no harm should be done.
>
> a bogus error message is written, 'Invalid object type' in
> mxt_get_object()
>

Ah, I see. There is a dev_err in mxt_get_object. In that case, my
suggestion to check mxt_get_object will also throw the same bogus
error message. Maybe that should be a dev_warn instead?

-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux