Re: [PATCH V2 00/14] Input: ALPS - Clean up and rework driver to support newer touchpads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 14, 2013 at 10:02:52AM -0800, Kevin Cernekee wrote:
> On Thu, Feb 14, 2013 at 9:17 AM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > Thank you very much, nice work! I applied the first 13 patches; waiting
> > for acknowledgements that Dolphin works before I apply it.
> 
> Dmitry,
> 
> A couple of us were working behind the scenes on a third spin of the
> patchset.  There was one change that affected patches #07-13:
> 
>  - Remove unused "resp" parameter from alps_enter_command_mode() (minor cleanup)
> 
> And several more improvements/fixes to the Dolphin patch #14:
> 
>  - Distinguish between Dolphin V1 and V2 in alps_identify() and use
> different init sequences
>  - Take Dolphin out of the alps_model_data table, so that we can check
> the second byte of the EC report
>  - Use the Dave T / Florin V1 init sequence verbatim if it's V1
>  - Update the V2 init sequence to more closely match the binary
> driver, and fix some bugs
> 
> #14 should definitely not be applied as-is.  #01-13 should be safe to
> apply, or if you want, I'll post the new versions instead.
> 
> I believe the new version of the Dolphin patch is working correctly
> for Dolphin V1.  Basic Dolphin V2 functionality is "OK" but there
> still seems to be an issue properly sensing pressure values at the
> edges of the touchpad, which might mean that the reports aren't being
> decoded correctly.  As a result, users have reported that edge
> scrolling is not working very well.

OK, so maybe we should merge the latest version of the patch but
temporarily disable the V2 support until you work out the kinks?

Anyway, please send the new patches relative to what is my 'next'
branch.

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux