On Sun, 6 Jan 2013 16:44:59 +0530, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote: > The NVIDIA's Tegra KBC has maximum 24 pins to make matrix keypad. > Any pin can be configured as row or column. The maximum column pin > can be 8 and maximum row pin can be 16. > > Remove the assumption that all first 16 pins will be used as row > and remaining as columns and Add the property for configuring pins > to either row or column from DT. Update the devicetree binding > document accordingly. > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > --- > Changes from V1: > - renames the rows and pins property array. > - nit cleanups. > Changes from V2/V3: > None > > .../bindings/input/nvidia,tegra20-kbc.txt | 22 ++++++ > drivers/input/keyboard/tegra-kbc.c | 74 +++++++++++++++----- > 2 files changed, 79 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt b/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt > index 72683be..2995fae 100644 > --- a/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt > +++ b/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt > @@ -1,7 +1,18 @@ > * Tegra keyboard controller > +The key controller has maximum 24 pins to make matrix keypad. Any pin > +can be configured as row or column. The maximum column pin can be 8 > +and maximum row pins can be 16 for Tegra20/Tegra30. > > Required properties: > - compatible: "nvidia,tegra20-kbc" > +- reg: Register base address of KBC. > +- interrupts: Interrupt number for the KBC. > +- nvidia,kbc-row-pins: The KBC pins which are configured as row. This is an > + array of pin numbers which is used as rows. > +- nvidia,kbc-col-pins: The KBC pins which are configured as column. This is an > + array of pin numbers which is used as column. > +- linux,keymap: The keymap for keys as described in the binding document > + devicetree/bindings/input/matrix-keymap.txt. For the binding: Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
