On Mon, Feb 11, 2013 at 4:53 PM, Pandruvada, Srinivas <srinivas.pandruvada@xxxxxxxxx> wrote: > This was added to load sensor hub driver on USB plug in without explicit modprobe. > But with last few changes to remove vendor and product id, we need to do modprobe this driver. > So removal is OK. I just figure your comment out: the change does not seem to have anything to do with hotplugging. .usage_table is used to decide which HID reports to forwards to the .event() callback, and NULL means all events. So even if it was in use, there are no functional changes. Thanks to the changes to remove the vendor id and product id, you shouldn't have to manually modprobe the driver as the hid-core subsystem will tag the hid device as a sensor one, meaning that udev will modprobe the driver if it's not already loaded. So if you still have to manually modprobe your driver (or maybe you are talking about the mfd driver), there is a bug in the detection of sensors devices. And this has to be fixed :) Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
