Hi Koen, > <SNIP> > > > > Since AM335x is DT only, why is there a platform data codepath and why is it the first branch it tries? And I guess the next question is related to the first: why doesn't it work when used with DT? When I copy over the nodes from the evm.dts to my board I get "tsc tsc: Missing platform data" in dmesg. > > > > > > This IP came up 1st on AM335x, but it is not platform dependent. The driver can be used on other platforms where-in DT is not supported. > > > According to the maintainers platform data takes precedence over DT. Hence the order. > > > > > > > Rachana, > > > > I see no point adding support for platform_data when you know that none of older platforms are going to use this driver and all future platforms _must_ follow device-tree model. > > > > So I agree that you should remove board file dependency from the driver. > > Ok. I will remove support for platform data in the next version of patches. > > > > > > > > I do not see "Missing platform data" error msg in the latest driver. I am not able to trace from where this got populated. > > > > > > > Can you share the branch which you have tested? > > https://github.com/patilrachna/linux/tree/v3.8_rc3_MFD_TSCADC_DT-v2 Did you get a chance to test this branch? And can you also share your branch, on which you observed the issue. Regards, Rachna -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html