Alan Cox <alan@xxxxxxxxxxxxxxx> wrote: >On Wed, 23 Jan 2013 20:15:47 -0800 >Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > >> Hi Alan, >> >> On Wed, Jan 23, 2013 at 05:38:43PM +0000, Alan Cox wrote: >> > From: Brian Swetland <swetland@xxxxxxxxxx> >> > >> > This device is a direct pipe from "hardware" to the input >> > event subsystem, allowing us to avoid having to route >> > "keypad" style events through an AT keyboard driver (gross!) >> > >> > As with the other submissions this driver is cross architecture. >> > >> > Signed-off-by: Mike A. Chan <mikechan@xxxxxxxxxx> >> > [Tided up to work on x86] >> > Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx> >> > Signed-off-by: Yunhong Jiang <yunhong.jiang@xxxxxxxxx> >> > Signed-off-by: Xiaohui Xin <xiaohui.xin@xxxxxxxxx> >> > Signed-off-by: Jun Nakajima <jun.nakajima@xxxxxxxxx> >> > Signed-off-by: Bruce Beare <bruce.j.beare@xxxxxxxxx> >> > [Ported to 3.4] >> > Signed-off-by: Tom Keel <thomas.keel@xxxxxxxxx> >> > [Cleaned up for 3.7 and submission] >> > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> >> >> I do not have drivers/tty/goldfish.c so I dropped that change... I >> also had a few more cleanups, the result is below. > >Looks good to me - I wasn't sure about the remove method so I copied >the other keyboard drivers that still had one even though they used >devm_ methods for the allocation. > Probably because some other resources are not devm managed and we need to preserve order. Or maybe just bugs... Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
