Re: [PATCH v2] HID: add ThingM blink(1) USB RGB LED support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> > > Shouldn't the name presented in the sys/class/leds directories
> > > change
> > > appropriately too?
> > 
> > The directory name for the device under /sys/class/leds is
> > "blink(1)::<serial>",
> > where <serial> is the last 4 digits of the device serial number
> > (the first 4
> > digits are always the same: "1A00"). For instance,
> > "blink(1)::1234".
> > Let me know if I misunderstood your question.
> 
> I believe that Simon's (valid) observation is that the sysfs path
> should
> reflect the name change, i.e. something along the lines of
> /sys/class/leds/thingm-blink:<serial>   ... ?

The vendor's name is "ThingM" and the product's name is "blink(1)", not "blink".
Given that, would you prefer to keep "blink(1)::1234", or would it rather be
"thingm-blink1::1234" (avoiding parenthesis)?

I ask the same question for the driver name, which is actually "blink(1)".

Thanks,
Vivien
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux