Re: [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon

On Thu, Jan 17, 2013 at 10:02 PM, Simon Que <sque@xxxxxxxxxxxx> wrote:
> This variable is initialized conditionally, based on whether a wiimote
> call succeeds.  However, the logic is not obvious to the compiler so it
> throws a warning.  Eliminate the warning by initializing "size" to 0.
>
> The warning is:
> files/drivers/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
> uninitialized in this function [-Wmaybe-uninitialized]

Thanks!

Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx>

> Signed-off-by: Simon Que <sque@xxxxxxxxxxxx>
> ---
>  drivers/hid/hid-wiimote-debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c
> index eec3291..90124ff 100644
> --- a/drivers/hid/hid-wiimote-debug.c
> +++ b/drivers/hid/hid-wiimote-debug.c
> @@ -31,7 +31,7 @@ static ssize_t wiidebug_eeprom_read(struct file *f, char __user *u, size_t s,
>         unsigned long flags;
>         ssize_t ret;
>         char buf[16];
> -       __u16 size;
> +       __u16 size = 0;
>
>         if (s == 0)
>                 return -EINVAL;
> --
> 1.7.8.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux