Hi Dmitry, On 01/10/2013 06:54 PM, Dmitry Torokhov wrote: > Hi Peter, > > On Thu, Jan 10, 2013 at 02:36:05PM +0100, Peter Ujfalusi wrote: >> Convert the probe to use devm_*. At the same time reorder the calls >> so we will register the input device as the last step when the driver >> is loaded. > > If you are doing this please also use devm_input_allocate_device() and > devm_regulator_bulk_get(). Now I remember: I can not switch to devm_regulator_bulk_get() unfortunately since when we boot with DT the code needs to reach up for the parent's dev to get the needed regulator. If I use devm_regulator_bulk_get() the resource will be bind to the parent dev and not to the vibra driver. > I also think it is high time to get rid of > dedicated work queue - cwq hasn't actually given you a separate therad > for a while now and if you get rid of workqueue you can get ridof entire > twl6040_vibra_remove(). I agree with the rest. I'll move both twl4030/6040 vibra to use devm_input_allocate_device() and also I will move them to use system wide workqueue. I'm going to resend the series soon with the suggested changes. Thanks, Péter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
