> > > + pdata->irq_over_gpio = of_get_property(np, "irq-over-gpio", NULL); > > > > This is a new DT binding and you haven't provided any documentation for it. > > > > Also, there is no reason for the binding to exist. > > > > Lots of drivers use GPIO pins as IRQs. > > Right, this can be removed and only the 'irq-gpios' can be kept around. What do > you say? I don't like it to be honest. How many GPIOs does the STMPE driver need? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html