On Tue, 18 Dec 2012, Michael Karcher wrote: > Hello developers (and testers) > > The attached pad adds supports for another gamepad to the hid-pl driver. > The "color rumble pad P580" marketed using the "Saitek" brand in > Germany, and using a USB Vendor ID attributed to "Jess" seems to be > electronically identical to the 4-field variant of the "Green Asia" > gamepad. > > The pad has been tested to support rumble strengths up to 255, not just > 127. Currently the patch discriminates the pads by an if on the vendor > ID, a bit in the driver_data field with definitely do better, but I > recommend the owners of the 4-field green asia pad to verify whether the > maximum rumble strength is indeed only 127, otherwise the condition > should be removed entirely and 255 used in all cases. Hi Michael, thanks for the patch. A couple of requests before I can apply it: - please provide the patch in-line in the e-mail body if your client doesn't corrupt patches. It's eaiser to review it that way - please add your Signed-off-by: line as described in Documentation/SubmittingPatches - don't forget to add the VID/PID to hid_ignore_list[], otherwise the device <-> driver binding will not work properly Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
