Hi, Shawn, I plan to remove pinctrl code in the coming next version driver patch first. Do you think this is ok or not? 2012/12/31 Shawn Guo <shawn.guo@xxxxxxxxxx>: > Hi Liu, > > On Sun, Dec 30, 2012 at 03:28:52PM -0800, Dmitry Torokhov wrote: >> > @@ -473,6 +534,10 @@ static int imx_keypad_probe(struct platform_device *pdev) >> > goto failed_free_priv; >> > } >> > >> > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); >> > + if (IS_ERR(pinctrl)) >> > + dev_warn(&pdev->dev, "failed to get default pinctrl\n"); >> > + >> >> No, please let core do this for you. Linus has a patch doing just that. >> > FYI. Dmitry is talking about the patch[1] below. Unfortunately, you > will not be able to base your patch on that until v3.9-rc1. > > Shawn > > [1] http://thread.gmane.org/gmane.linux.kernel/1409263 > -- Liu Ying -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
