On Mon, Nov 5, 2012 at 1:25 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > On 4 November 2012 19:12, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: >> If I understand correctly, the only "real" solution is to >> implement the PM domains and have these enable the clocks. > > Agree. > > Although, since the pm_domain not yet exist, this as a way forward for > now - to fix what is broken. True. Fixing regressions is more important. Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > When the pm_domain is in place and when we decide to fold in the clock > handling in there, we can move it. OK for me. >> An alternative may be to move this driver over to the AMBA bus, >> because I think this device actually has primecell registers. >> Then the bus will take care of the pclk for starters. > > You are definitely right, this driver can be converted into using the AMBA bus. > Although, do you think that should be done _instead_ of going ahead > with this patch or do you want that to be handled as a next and a > separate step? No, just a suggestion of possibilities... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html