Re: [PATCH] HID: Add driver for ION iCade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 31 Oct 2012, Bastien Nocera wrote:

> 
> Add a driver for the ION iCade mini arcade cabinet [1]. The device
> generates a key press and release for each joystick movement or
> button press or release. For example, moving the stick to the
> left will generate the "A" key being pressed and the released.
> 
> A list of all the combinations is available in the iCade
> developer guide [2].
> 
> This driver hides all this and makes the device work as a generic
> joystick.
> 
> [1]: http://www.ionaudio.com/products/details/icade
> [2]: http://www.ionaudio.com/downloads/iCade_Dev_Resource_v1.3.pdf
> 
> Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> ---
>  drivers/hid/Kconfig     |   9 ++
>  drivers/hid/Makefile    |   1 +
>  drivers/hid/hid-core.c  |   1 +
>  drivers/hid/hid-icade.c | 259 ++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/hid/hid-ids.h   |   3 +
>  5 files changed, 273 insertions(+)
>  create mode 100644 drivers/hid/hid-icade.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1630150..813f0fe 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -265,6 +265,15 @@ config HID_GYRATION
>  	---help---
>  	Support for Gyration remote control.
>  
> +config HID_ICADE
> +	tristate "ION iCade arcade controller"
> +	depends on (BT_HIDP)

Why the spurious brackets here?

Otherwise the patch looks good, thanks (and thanks Benjamin for review), I 
apply and remove the brackets.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux