Hi Scott, On Wed, Oct 24, 2012 at 09:41:43AM +0800, Scott Liu wrote: > This patch is for Elan eKTF Touchscreen product, I2C adpater module. > > Signed-off-by: Scott Liu <scott.liu@xxxxxxxxxx> > --- > > Hi, > v2 revision I have fixed some bug as your advise. > 1. To target the mainline > 2. No Android dependency > 3. reuse those duplication code from Henrik's patchset. > (input_mt_sync_frame() / input_mt_get_slot_by_key()) Just a quick run through the code, so: - please remove polling support, it is not useful in production; - why do you need a separate probe work instead of doing what you need in elants_probe() - it is not a good idea to register input device first and then allocating memory for MT handling. - I do not understand why kfifo is needed - please remove the rest of the custom threads - you do not need to call input_mt_destroy_slots() explicitly - use request_firmware() instead of special character device to upload firmware. - please use standard kernel-doc markup. - consider what attributes are there only for debugging and move them to debugfs. - I find the use of enums in this driver quite unconventional, just standard #defines would probably be more straightforward. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
