Re: [PATCH] HID: wiimote: add Nintendo-Wii-Remote-Plus IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Oct 2012, David Herrmann wrote:

> The newest revision of the Nintendo Wii Remote Plus uses new VID/PIDs. We
> already support these devices so we can simply add the IDs.
> 
> Reported-by: Peter Olson <peter.olson@xxxxxxxxx>
> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx>
> ---
> Hi Jiri
> 
> I am actually not sure why Nintendo changed the VID/PID for the newest
> revisions. I have a WiimotePlus which uses the old IDs and works fine. However,
> the Windows WiiMote driver developers reported to me that the protocol stayed
> the same so I just added the IDs.
> Please wait before applying this until I get a "Tested-by" from Peter (CC'ed).

Sure, thanks, waiting for the Tested-by: tag.

But I guess you also need the device id added to 
hid_have_special_driver[], which is missing in the patch ...

> 
> Thanks
> David
> 
>  drivers/hid/hid-ids.h          | 1 +
>  drivers/hid/hid-wiimote-core.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 753f3d6..b5c2231 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -583,6 +583,7 @@
>  
>  #define USB_VENDOR_ID_NINTENDO		0x057e
>  #define USB_DEVICE_ID_NINTENDO_WIIMOTE	0x0306
> +#define USB_DEVICE_ID_NINTENDO_WIIMOTE_2 0x0330
>  
>  #define USB_VENDOR_ID_NOVATEK		0x0603
>  #define USB_DEVICE_ID_NOVATEK_PCT	0x0600
> diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
> index 84e2fbe..c8a4325 100644
> --- a/drivers/hid/hid-wiimote-core.c
> +++ b/drivers/hid/hid-wiimote-core.c
> @@ -1283,6 +1283,8 @@ static void wiimote_hid_remove(struct hid_device *hdev)
>  static const struct hid_device_id wiimote_hid_devices[] = {
>  	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO,
>  				USB_DEVICE_ID_NINTENDO_WIIMOTE) },
> +	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO,
> +				USB_DEVICE_ID_NINTENDO_WIIMOTE_2) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(hid, wiimote_hid_devices);
> -- 
> 1.7.12.4
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux