Hi Dmitry, Thanks again for your quick reply. >> + void *data, *status; >These 2 should be annotated as __iomem. May I also suggest calling them data_addt and status_addr? I assume you meant data_addr. >> + dev_err(&pdev->dev, "memory allocation failed cannot get the I/O addr 0x%x\n", >> + (unsigned int)arc_ps2->iomem_res->start); > I think we have a format specifier for resources. Thanks, didn't know that! >> + iounmap((void __iomem *) arc_ps2->addr); > No need to cast to __iomem here. These are remains from the time that addr was still an 'unsigned' (while using inl/outl). Updated. Patch v3 will follow in due course. Thanks again, Mischa -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
