Re: [PATCH 1/2] input: qt2160: Fix I2C write function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,
thank you for your answer.

On 16 October 2012 19:31, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> On Tue, Oct 16, 2012 at 05:19:30PM +0200, Javier Martin wrote:
>> The previous implementation of qt2160_write() didn't work
>> properly. Use a similar aproach as qt1070 instead.
>
> I think your editor lost the end of the sentence: "... qt2160_write()
> didn't work properly because ..." :)
>
> Thanks!
>
> --
> Dmitry

Because the requested value was actually not written to the device.
Probably nobody detected this because the only write that was issued
was the one related to auto calibration.

It was while I was trying to add support for the LEDs when I realized
that they were not being powered on.

Do you want me to send a v2 patch with these information added to the changelog?

Regards.
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux