On Thu, 2012-10-11 at 02:49 +0000, Christopher Heiny wrote: > Joe Perches wrote: [] > > > + list_for_each_entry(entry, &data->rmi_functions.list, list) > > > + if (entry->irq_mask) > > > + process_one_interrupt(entry, irq_status, > > > + data); > > > > style nit, it'd be nicer with braces. > > I agree with you, but checkpatch.pl doesn't. :-( Sure it does. $ cat t.c { list_for_each_entry(entry, &data->rmi_functions.list, list) { if (entry->irq_mask) process_one_interrupt(entry, irq_status, data); } } $ ./scripts/checkpatch.pl --strict -f t.c total: 0 errors, 0 warnings, 0 checks, 7 lines checked t.c has no obvious style problems and is ready for submission. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html