On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxx> wrote: > Hi, > > thanks also for the review. Two in the same day! I was about to send a > ping on that patch.... ;-) > > On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta > <omaplinuxkernel@xxxxxxxxx> wrote: >> On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires >> <benjamin.tissoires@xxxxxxxxx> wrote: >>> From: Benjamin Tissoires <benjamin.tissoires@xxxxxxx> >>> >>> Microsoft published the protocol specification of HID over i2c: >>> http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx >>> >>> This patch introduces an implementation of this protocol. >>> >>> This implementation does not includes the ACPI part of the specification. >>> This will come when ACPI 5.0 devices will be available. >>> >>> Once the ACPI part will be done, OEM will not have to declare HID over I2C >>> devices in their platform specific driver. >>> >>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxx> >>> --- >>> >>> Hi, >>> >>> this is finally my first implementation of HID over I2C. >>> >>> This has been tested on an Elan Microelectronics HID over I2C device, with >>> a Samsung Exynos 4412 board. >>> >>> Any comments are welcome. >>> >>> Cheers, >>> Benjamin >>> >>> drivers/i2c/Kconfig | 8 + >>> drivers/i2c/Makefile | 1 + >>> drivers/i2c/i2c-hid.c | 1027 +++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/i2c/i2c-hid.h | 35 ++ >>> 4 files changed, 1071 insertions(+) >>> create mode 100644 drivers/i2c/i2c-hid.c >>> create mode 100644 include/linux/i2c/i2c-hid.h >>> >>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >> [...] > > same thing, will change it in v2. > >> >>> + >>> + if (debug) >>> + dev_err(&client->dev, "resetting...\n"); >> this is a little uncustomary. >> >> May be consider bdg > > Sorry for that. I don't get your point here. You don't like the whole > "if(debug) dev_err(...)" or just the "dev_err(...)" call? > Apologies for the typo dev_dbg. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
