Re: HID: picoLCD: optimize for inactive debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 30 Sep 2012, Bruno Prémont wrote:

> Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when
> there is an active listener on debugfs for events.
> 
> His change got lost while splitting hid_picolcd.c, restore it.
> 
> Signed-off-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx>
> ---
> 
> 
> diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
> index 6ef03be..4809aa1 100644
> --- a/drivers/hid/hid-picolcd_debugfs.c
> +++ b/drivers/hid/hid-picolcd_debugfs.c
> @@ -402,7 +402,7 @@ void picolcd_debug_out_report(struct picolcd_data *data,
>  #define BUFF_SZ 256
>  
>  	/* Avoid unnecessary overhead if debugfs is disabled */
> -	if (!hdev->debug_events)
> +	if (list_empty(&hdev->debug_list))
>  		return;
>  
>  	buff = kmalloc(BUFF_SZ, GFP_ATOMIC);

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux