Re: [PATCH] input: pwm-beeper: Add devicetree probing support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 25, 2012 at 09:15:51AM +0200, Sascha Hauer wrote:
[...]
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index fc84c8a..dfb3c50 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
[...]
> @@ -171,6 +175,11 @@ static SIMPLE_DEV_PM_OPS(pwm_beeper_pm_ops,
>  #define PWM_BEEPER_PM_OPS NULL
>  #endif
>  
> +static const struct of_device_id pwm_beeper_match[] = {
> +	{ .compatible = "pwm-beeper", },
> +	{ },
> +};
> +

This is usually protected by #ifdef CONFIG_OF...

>  static struct platform_driver pwm_beeper_driver = {
>  	.probe	= pwm_beeper_probe,
>  	.remove = __devexit_p(pwm_beeper_remove),
> @@ -178,6 +187,7 @@ static struct platform_driver pwm_beeper_driver = {
>  		.name	= "pwm-beeper",
>  		.owner	= THIS_MODULE,
>  		.pm	= PWM_BEEPER_PM_OPS,
> +		.of_match_table = pwm_beeper_match,

... and this of_match_ptr(pwm_beeper_match). They aren't technically
necessary but I guess it makes sense to not keep them around for !OF
configurations in order to save some bytes.

Thierry

Attachment: pgpYRMJop0ZBl.pgp
Description: PGP signature


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux