Re: [PATCH 1/4] HID: hid-lg4ff: Minor code cleanup to improve readability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 24 Sep 2012, Michal Malý wrote:

> This patch replaces all occurrences of "report->field[0]->value[n]" with just "value[n]" to get rid of the lengthy trains we have now.
> 
> Signed-off-by: Michal Malý <madcatxster@xxxxxxxxx>
> ---
> >From bad52be1762f00ed4dbe7c5a21cbfe9d9d0f4428 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20Mal=C3=BD?= <madcatxster@xxxxxxxxx>
> Date: Wed, 27 Jun 2012 12:09:33 +0200
> Subject: [PATCH 1/4] Replace "report->field[0]->value[n]" with "value[n]" for
>  better code readability.
> 
> ---
>  drivers/hid/hid-lg4ff.c | 121 +++++++++++++++++++++++++-----------------------
>  1 file changed, 64 insertions(+), 57 deletions(-)

Michal,

thanks for the patches. I am applying the series, but please note the 
following comments:

- please submit your patches in a way that they can be properly applied by 
  'git-am'. The way you are sending those will cause the changelog to be 
  lost, as git-am would pick up only the part that was generated by 
  git-format-patch, which is after your changelog
- 4/4 has been line-wrapped. I have fixed that up by hand.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux