On Mon, Sep 24, 2012 at 09:05:59PM +0200, Lars-Peter Clausen wrote: > On 09/24/2012 08:49 PM, Sascha Hauer wrote: > > > > My bad, I missed that platform_data is casted to an unsigned long. I > > thought I would test for a pointer. > > The obvious clean way would be to use a pointer for platform_data, but > > given that this will vanish anyway soon, I think we could just test for > > existence of dev->of_node instead of dev->platform_data. > > I think the plan is to convert the existing board file platforms to pwm_table > and then remove the old pwm_request API. So this wouldn't work too well if we'd > test for of_node. Maybe we can just run pwm_get unconditionally and fallback to > pwm_request if it failed. That's also what the PWM backlight driver currently does. Fine with me. > > > > >> > >> Yes, this a bit tricky, but we only have a single in-tree user of the > >> pwm-beeper which uses a id != 0. And now that all the PWM providers have > >> been converted to the new generic PWM framework the old legacy API will go > >> away soon anyway. So this if () else branch should hopefully only be > >> necessary for a transitional period of 1-2 releases. So I think this change > >> should be OK. > >> > >> But I think the patch is missing a change to the Kconfig entry to allow the > >> driver to be selected if the generic PWM framework is available. > >> > >> --- a/drivers/input/misc/Kconfig > >> +++ b/drivers/input/misc/Kconfig > >> @@ -444,7 +444,7 @@ config INPUT_PCF8574 > >> > >> config INPUT_PWM_BEEPER > >> tristate "PWM beeper support" > >> - depends on HAVE_PWM > >> + depends on HAVE_PWM || PWM > > > > Is this the preferred way to do this? Instead of doing the above I added > > a 'select HAVE_PWM' to the pwm framework instead. I found a patch for that, > > but there were comments to it that this is not good > > > > Thierry said that this is his preferred solution. Given that HAVE_PWM will be > extinct soon anyway I think it is fine. Ok. Will send an updated patch tomorrow. Thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
