On Fri, Sep 14, 2012 at 13:50:57, Jonathan Cameron wrote: > On 14/09/12 07:00, Patil, Rachna wrote: > > On Thu, Sep 13, 2012 at 17:43:30, Jonathan Cameron wrote: > >> On 13/09/12 11:40, Patil, Rachna wrote: > >>> This patch adds support for TI's ADC driver. > >>> This is a multifunctional device. > >>> Analog input lines are provided on which voltage measurements can be > >>> carried out. > >>> You can have upto 8 input lines. > >>> > >>> Signed-off-by: Patil, Rachna <rachna@xxxxxx> > >> > >> There's a little fuzz in applying this due to other drivers that have gone in recently. > >> > >> Actually this is going to be 'interesting' to merge. Dmitry, Samuel thoughts on who takes this one and how? Maybe this is a case for a 'special' branch pulled into more than one tree? > >> > >> > >> One minor thing inline. I have an aversion to dynamic allocation of > >> things that are then constant. > >> > >> Also the module name is simply ti_adc. Does seem a little 'vague' > >> given the range of ADC's TI makes :) Perhaps keep the reference to > >> the tsc in there? Personally I'd have preferred the whole thing > >> being named after a particular part number (any one it support would > >> do) to avoid a clash in future with a new touch screen adc from TI. > >> Bit late for that though I guess ;) > > > > Yes, true. > > TI definitely might come up with more IP's of this type. > > This IP(TSC / ADC) is present on AM335x. If necessary we can rename the driver to ti_am335x_XXX. > I'd be in favour of doing this now rather than when the problem presents itself. Anyone mind? I will also rename the touchscreen and the MFD driver to reflect the same. <SNIP> Regards, Rachna -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
